Output details omitted from secpod_dangerous_activex_ctrl.nasl

Vulnerability Tests
1

I noticed that 2009/secpod_dangerous_activex_ctrl.nasl does not properly construct its security_message report. It appears to be using a comma instead of “+” to concatenate the detected clsid messages to the message header, giving the following output:

<description>The following CLSID(s) were found on the remote host, which are related to dangerous ActiveX controls:</description>

A sample diff that appears to generate the correct output is:

<   security_message(data:"The following CLSID(s) were found on the remote host, which are related to dangerous ActiveX controls:" + actvxInfo);
---
>   security_message(data:"The following CLSID(s) were found on the remote host, which are related to dangerous ActiveX controls:", actvxInfo);
1 Like
2

Hello and welcome to this community portal.

This is a great catch. Unfortunately the openvas linter (openvas-nasl-lint) isn’t capable to catch such cases so it seems it got unnoticed before your finding.

I just have submitted a fix (including some additional clean ups) for a review by the feed team, the changes should arrive in the feed in the next few days.

2 Likes